Hello, On Fri, Dec 23, 2016 at 10:20:20AM +0200, Vladimir Zapolskiy wrote: > On 12/23/2016 03:55 AM, Guenter Roeck wrote: > > What is the ultimate conclusion of this exchange ? > > > > Are we going to get another version of the patch, or did everyone agree that > > the patch is good as it is and does not require further changes ? > > > > I can not imagine a different fix. my preferred fix would be: - add an imx35 compatible to all newer dtsi - update the driver to only write the wmcr on imx35 compatible devices adding only imx35. Compared to Vladimir's change this undoes 5fe65ce7ccbb ("watchdog: imx2_wdt: Disable power down counter on boot") on the newer generation SoCs until their dtb is updated. 5fe65ce7ccbb fixed a problem in 2014 for these newer SoCs which wasn't urgent enough to be fixed earlier, so I'd say this isn't a big problem and in return the drivers and device trees stay simpler. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html