On 12/23/2016 03:55 AM, Guenter Roeck wrote: > On 12/11/2016 03:21 AM, Vladimir Zapolskiy wrote: >> On 12/11/2016 12:26 PM, Uwe Kleine-König wrote: >>> Hello Vladimir, >>> >>> On Sun, Dec 11, 2016 at 12:01:08PM +0200, Vladimir Zapolskiy wrote: >>>> On 12/11/2016 11:35 AM, Uwe Kleine-König wrote: >>>>> On Sun, Dec 11, 2016 at 03:06:48AM +0200, Vladimir Zapolskiy wrote: >>>>>> Power down counter enable/disable bit switch is located in WMCR >>>>>> register, but watchdog controllers found on legacy i.MX21, i.MX27 and >>>>>> i.MX31 SoCs don't have this register. As a result of writing data to >>>>>> the non-existing register on driver probe the SoC hangs up, to fix the >>>>>> problem add more OF compatible strings and on this basis get >>>>>> information about availability of the WMCR register. >>>>>> >>>>>> Fixes: 5fe65ce7ccbb ("watchdog: imx2_wdt: Disable power down counter on boot") >>>>>> Signed-off-by: Vladimir Zapolskiy <vz@xxxxxxxxx> >>>>>> --- >>>> > > > What is the ultimate conclusion of this exchange ? > > Are we going to get another version of the patch, or did everyone agree that > the patch is good as it is and does not require further changes ? > I can not imagine a different fix. -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html