On 01/03/2016 03:32 AM, Tomas Winkler wrote:
ref/unref ops are not called at all so even marked them as deprecated is misleading, we need to just drop the API.
One the other side, the functions are now no-ops, so they don't hurt either. Only reason for not dropping the functions as part of my series was that the mei watchdog code was starting to implement them, and I didn't want to create dependencies for that code. Maybe my thinking was too conservative.
Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
... of course that is no concern anymore since this patch is from its maintainer. Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx> Thanks! Guenter
--- include/linux/watchdog.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h index 850af04fe0c7..aaabd4703b46 100644 --- a/include/linux/watchdog.h +++ b/include/linux/watchdog.h @@ -47,8 +47,6 @@ struct watchdog_ops { int (*set_timeout)(struct watchdog_device *, unsigned int); unsigned int (*get_timeleft)(struct watchdog_device *); int (*restart)(struct watchdog_device *); - void (*ref)(struct watchdog_device *) __deprecated; - void (*unref)(struct watchdog_device *) __deprecated; long (*ioctl)(struct watchdog_device *, unsigned int, unsigned long); };
-- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html