Hi Thomas,
On 30 December 2015 at 22:02, Thomas Petazzoni
<thomas.petazzoni@xxxxxxxxxxxxxxxxxx> wrote:
> Hello,
>
> On Wed, 30 Dec 2015 21:30:08 +0800, Fu Wei wrote:
>
>> > Maybe we should enforce that all users of the driver use two Device
>> > Tree compatible strings:
>> >
>> > compatible = "<vendor>,sbsa-gwdt", "arm,sbsa-gwdt";
>> >
>> > So that the SBSA watchdog driver can implement vendor specific quirks
>> > if needed. Though it is true that the HW has some identification
>> > registers that should allow to differentiate between the implementation.
>>
>> I think the implementation can be different, but all the SBSA watchdog
>> should be able to use the same driver.
>
> Yes, they *should*, but as Guenter said, since the specification is not
> very clear, it is quite likely that some HW implementations will not
> behave exactly like others, so the driver will likely need to have some
> quirks to adapt to those subtle differences between implementations.
As Guenter said, the specification is not very clear. Yes, agree, my
colleagues also have this feeling.
if there are some problems in the spec, maybe we can suggest ARM
engineer improving that
Because the SBSA spec defines the device, I think a "so-called" SBSA
watchdog can be added more useful features,
but it should follow all the description in the spec at least, then
the SBSA watchdog driver can be a common driver for all this devices.
For now what we can do is testing the common driver on the different
platform as much as we can. See if the driver can work,
I have tested my driver on:
(1)ARM Foundation v8 model
(2)AMD Seattle platform
maybe there are some other platform has this watchdog, If I can test
the driver on them, that would be great.
>
>> > For now, I'm personally fine with a SBSA driver that does not support
>> > the pretimeout. Is anyone working on submitting something like this ?
>>
>> I am working on a new non-pretimeout SBSA driver.
>
> Ok, great. Can you Cc: me when you send this new version ?
>
yes, NP, will do definitely. Great thanks for your feedback.
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
Best regards,
Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
