Hello, On Wed, 30 Dec 2015 21:30:08 +0800, Fu Wei wrote: > > Maybe we should enforce that all users of the driver use two Device > > Tree compatible strings: > > > > compatible = "<vendor>,sbsa-gwdt", "arm,sbsa-gwdt"; > > > > So that the SBSA watchdog driver can implement vendor specific quirks > > if needed. Though it is true that the HW has some identification > > registers that should allow to differentiate between the implementation. > > I think the implementation can be different, but all the SBSA watchdog > should be able to use the same driver. Yes, they *should*, but as Guenter said, since the specification is not very clear, it is quite likely that some HW implementations will not behave exactly like others, so the driver will likely need to have some quirks to adapt to those subtle differences between implementations. > > For now, I'm personally fine with a SBSA driver that does not support > > the pretimeout. Is anyone working on submitting something like this ? > > I am working on a new non-pretimeout SBSA driver. Ok, great. Can you Cc: me when you send this new version ? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
