> >>> +#if IS_ENABLED(CONFIG_DEBUG_FS) > >>> +static const char *mei_wdt_state_str(enum mei_wdt_state state) > >>> +{ > >>> + switch (state) { > >>> + case MEI_WDT_IDLE: return "IDLE"; > >>> + case MEI_WDT_START: return "START"; > >>> + case MEI_WDT_RUNNING: return "RUNNING"; > >>> + case MEI_WDT_STOPPING: return "STOPPING"; > >>> + default: return "unknown"; > >> > >> Doesn't this cause checkpatch warnings ? > > It doesn't and also checkpatch.pl is just a help tool. > > I should have said "Doesn't this violate the single-statement-per-line" > coding style rule, but I guess then you'd argue that "case xxx:" is not > a statement. I believe it is reasonably readable , but I don't have a strong feeling about it, if you do I can change it. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html