Re: [PATCH 1/2] watchdog: da9063: Ping watchdog only during allowed time window

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Philipp,

On 08/07/2015 10:08 AM, Philipp Zabel wrote:
Hi Guenter,

Am Freitag, den 07.08.2015, 06:36 -0700 schrieb Guenter Roeck:
On 08/06/2015 09:36 AM, Philipp Zabel wrote:
There is a cooldown period after watchdog timer setup, and also after each
watchdog ping. If a ping is issued too early, the watchdog triggers the
watchdog error condition and causes a system reset.

The 256 ms period length is a best guess based on the same value being used
for the DA9053 predecessor PMIC and experiments that have shown 200 ms are
not enough to avoid the error.

Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

Hi Philipp,

instead of using this quite complex approach, would it be possible to use the
same approach as the da9062 driver ?

I understand the downside, which is that the caller may end up sleeping,
but this should not happen too often.

Depending on the userspace this can happen quite a lot ...

Your call, ultimately. I don't want to spend time reviewing the changes
as is, given they are quite substantial and will ultimately go away,
so we'll just have to wait for someone else to spend that time.

Thanks,
Guenter

  Also, I plan to move the enforcement
of a minimal time between heartbeats into the infrastructure, so this would
not least forever.

... but certainly taking care of this in the framework is better than
doing it in the drivers.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux