On Tue, 28 Jul 2015, Matt Fleming wrote: > On Tue, 28 Jul, at 04:28:32PM, Lee Jones wrote: > > On Tue, 28 Jul 2015, Guenter Roeck wrote: > > > > > On 07/28/2015 08:00 AM, Lee Jones wrote: > > > >On Tue, 28 Jul 2015, Matt Fleming wrote: > > > >>On Tue, 28 Jul, at 12:37:21PM, Lee Jones wrote: > > > >>> > > > >>>The driver shouldn't be called that either. > > > >>> > > > >>>You are the only one. What makes iTCO 'special'? > > > >> > > > >>I don't know, I didn't write it. It looks like Wim did ~9 years ago, so > > > >>it must have made sense to him at the time. > > > >> > > > > > > Coding style wasn't as strict then as it is today. iTCO has just been kept > > > for historic reasons. > > > > For sure, I get that, but it doesn't mean we can't do-the-right-thing > > (tm) now does it? > > > > > Sure, we could have changed it to lowercase, but so far no one bothered. > > > Plus, of course, there is always the element that some maintainers hate > > > that kind of cleanup, > > > > Really? > > Yes, really. Well then they are silly (replace silly with something less ML friendly if you like). > > Surely any kind of clean-up is good clean-up. Especially as Greg KH > > et. al, have been doing public presentations telling everyone that > > there is always kernel work for anyone who has the time; spelling > > corrections and all. > > That's what staging/ was invented for ;-) Greg is quite happy to take > those patches, other maintainers are less so. No, staging was designed to take drivers which are either controversial or still in a state of flux. Not to over-rule maintainers which didn't think a clean-up was important enough for acceptance. > > Either do the 5min clean-up or don't, no biggy. If you don't then I > > can do it. > > Go for it. > > > At the very least please don't add any _new_ camel case variables or > > filenames. > > OK, sure. Great. Resubmit when ready. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
