Hi Naidu,
Just a few nitpicks on my side. See below.
On 11/21/2014 04:25 PM, naidu.tellapati@xxxxxxxxx wrote:
> From: Jude Abraham <Jude.Abraham@xxxxxxxxxx>
>
> This commit adds support for ImgTec PowerDown Controller Watchdog Timer.
>
> Signed-off-by: Jude Abraham <Jude.Abraham@xxxxxxxxxx>
> Signed-off-by: Naidu Tellapati <Naidu.Tellapati@xxxxxxxxxx>
> Reviewed-by: Andrew Bresticker <abrestic@xxxxxxxxxxxx>
[..]
> +
> +struct pdc_wdt_dev {
> + struct device *dev;
'dev' is unused.
> + struct watchdog_device wdt_dev;
> + struct clk *wdt_clk;
> + struct clk *sys_clk;
> + unsigned long clk_rate;
'clk_rate' is unused.
> + int min_delay;
> + void __iomem *base;
> +};
> +
[..]
> +
> +/* Start the watchdog timer (delay should already be set */
Typo here: missing closing parenthesis.
[..]
> +
> +static int pdc_wdt_probe(struct platform_device *pdev)
> +{
> + int ret, val;
> + struct resource *res;
> + struct pdc_wdt_dev *pdc_wdt;
> +
> + pdc_wdt = devm_kzalloc(&pdev->dev, sizeof(*pdc_wdt), GFP_KERNEL);
> + if (!pdc_wdt)
> + return -ENOMEM;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + pdc_wdt->base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(pdc_wdt->base))
> + return PTR_ERR(pdc_wdt->base);
> +
> + pdc_wdt->sys_clk = devm_clk_get(&pdev->dev, "sys");
> + if (IS_ERR(pdc_wdt->sys_clk)) {
> + dev_err(&pdev->dev, "failed to get the sys clock.\n");
> + ret = PTR_ERR(pdc_wdt->wdt_clk);
> + goto out_wdt;
I'd say remove all uses of the out_wdt label and just return ret.
Reviewed-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxx>
Wim: Any comments? We're aiming at having this driver merged for v3.19.
Thanks!
--
Ezequiel
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
