On 09/20/2014 09:15 AM, Carlo Caione wrote:
On Sat, Sep 20, 2014 at 5:30 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
On 09/19/2014 01:36 PM, Carlo Caione wrote:
This patch adds the watchdog driver for the Amlogic Meson SoCs used also
to reboot the device.
Signed-off-by: Carlo Caione <carlo@xxxxxxxxxx>
---
[ ... ]
+module_param(nowayout, bool, 0);
+MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started "
+ "(default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
+
Checkpatch says:
WARNING: quoted string split across lines
#295: FILE: drivers/watchdog/meson_wdt.c:231:
+MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started "
+ "(default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
Thought that it was "somehow tolerated" :)
Not me, at least not in this case.
But since I'm wrong I'll submit a v4.
MODULE_PARAM_DESC(nowayout,
"Watchdog cannot be stopped once started (default="
__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
is a really simple way of ensuring that you meet both the 80-column limit
and avoid the warning. The idea should not be to try to get away with
as many checkpatch warnings as possible ;-).
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
