2014-09-15 7:01 GMT+04:00, Guenter Roeck <linux@xxxxxxxxxxxx>: > On 09/14/2014 12:33 PM, Sergey Ryazanov wrote: >> Signed-off-by: Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx> >> Cc: Wim Van Sebroeck <wim@xxxxxxxxx> >> Cc: linux-watchdog@xxxxxxxxxxxxxxx >> --- >> arch/mips/ar231x/ar2315.c | 26 +++++- >> drivers/watchdog/Kconfig | 7 ++ >> drivers/watchdog/Makefile | 1 + >> drivers/watchdog/ar2315-wtd.c | 202 >> ++++++++++++++++++++++++++++++++++++++++++ > > This should be two patches: One to instantiate the watchdog, > the second the watchdog driver itself. The weatchdog driver > should use the watchdog infrastructure. > Ok. Will do in v2. [skipped] >> + * >> + * Copyright (C) 2008 John Crispin <blogic@xxxxxxxxxxx> >> + * Based on EP93xx and ifxmips wdt driver > > 2008 ? > Yes. This driver is pretty old. [skipped] >> + >> +#define CLOCK_RATE 40000000 >> +#define HEARTBEAT(x) (x < 1 || x > 90 ? 20 : x) >> + > Whatever the logic is here, it does not make much sense to me. > 90 second is maximal value which we could write to register, and value below 1 second is senseless. So this macros always return a value which make sense: specified by user or default. -- BR, Sergey -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
