On Fri, May 02, 2014 at 04:52:12PM -0500, Corey Minyard wrote: [ ... ] > > I do agree that the driver should be moved over to use the framework. > Implementing read/poll should be easy in the framework. > If it isn't essential, I would prefer to drop it for now. Otherwise, you'll have to convince Wim to accept it. I am personally not convinced that it is worthwhile. Eother case, the core changes should be a separate patch (or set of patches), so the work can be independent of each other. [ We might want to explore if a sysfs attribute would make more sense than the poll/fasync changes, for example ] In this context, does the driver have to reside in the ipmi directory ? It would be better to have it in the watchdog directory; that would ensure that the watchdog maintainer is involved if there are changes. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html