Hello. On 03-03-2011 13:03, John Crispin wrote:
This patch adds the driver for the watchdog found inside the Lantiq SoC family.
Signed-off-by: John Crispin<blogic@xxxxxxxxxxx> Signed-off-by: Ralph Hempel<ralph.hempel@xxxxxxxxxx> Cc: Wim Van Sebroeck<wim@xxxxxxxxx> Cc: linux-mips@xxxxxxxxxxxxxx Cc: linux-watchdog@xxxxxxxxxxxxxxx
[...]
diff --git a/drivers/watchdog/lantiq_wdt.c b/drivers/watchdog/lantiq_wdt.c new file mode 100644 index 0000000..d49ddaa --- /dev/null +++ b/drivers/watchdog/lantiq_wdt.c @@ -0,0 +1,235 @@
[...]
+static void +ltq_wdt_disable(void) +{ +#ifndef CONFIG_WATCHDOG_NOWAYOUT + ltq_wdt_ok_to_close = 0; +#endif + /* write the first paswword magic */
^ You still didn't fix the typo here. :-)
+ ltq_w32(LTQ_WDT_PW1, ltq_wdt_membase + LTQ_WDT_CR); + /* write the second paswword magic with no config
^ And here...
+static int +ltq_wdt_probe(struct platform_device *pdev)
Should be __init now that you're using platform_driver_probe()...
+ /* we do not need to enable the clock as it is always running */ + clk = clk_get(&pdev->dev, "io"); + if (!clk) + BUG();
BUG_ON(!clk);
+static struct platform_driver ltq_wdt_driver = { + .probe = ltq_wdt_probe,
No need to initialize it now that you're using platform_driver_probe()...
+ .remove = ltq_wdt_remove,
Shouldn't 'ltq_wdt_remove' be enclosed in __exit_p()? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html