Re: [PATCH V2 05/10] MIPS: lantiq: add watchdog support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 03-03-2011 13:15, Jamie Iles wrote:

+static int
+ltq_wdt_remove(struct platform_device *dev)

    __exit?

No, I think this should be __devexit and the probe function should be
__devinit.  When assigning the exit function to the platform_driver it
should be surrounded with __devexit_p().

   Why? Is WDT really a hotplug device?

Jamie

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux