>>
>> The first interrupt of the device is used to notify the host about
>> device configuration changes, such as link status updates. The ISR
>> configuration area is updated to indicate a config change event when
>> triggered.
>>
>> Signed-off-by: Satha Rao <skoteshwar@xxxxxxxxxxx>
>> Signed-off-by: Shijith Thotton <sthotton@xxxxxxxxxxx>
>> ---
>> drivers/vdpa/octeon_ep/octep_vdpa_main.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_main.c
>b/drivers/vdpa/octeon_ep/octep_vdpa_main.c
>> index 482c178a5221..6db951c6cb92 100644
>> --- a/drivers/vdpa/octeon_ep/octep_vdpa_main.c
>> +++ b/drivers/vdpa/octeon_ep/octep_vdpa_main.c
>> @@ -74,6 +74,14 @@ static irqreturn_t octep_vdpa_intr_handler(int irq,
>void *data)
>> }
>> }
>>
>> + /* Check for config interrupt. Config uses the first interrupt */
>> + if (unlikely(ring_start == 0 && ioread8(oct_hw->isr))) {
>> + iowrite8(0, oct_hw->isr);
>> +
>> + if (likely(oct_hw->config_cb.callback))
>
>Adding unlikely() and likey() hurts readability. It adds noise. You should do
>it if it makes a difference on a benchmark but that seems unlikely here.
>
Yes, this one can be removed. I will do it.
Thanks,
Shijith
