Re: [PATCH RFC 3/5] pci: add pci_iomap_range

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 11, 2014 at 11:27:54PM +0100, Arnd Bergmann wrote:
> On Thursday 11 December 2014 21:37:34 Michael S. Tsirkin wrote:
> >         if (flags & IORESOURCE_MEM) {
> > -               if (flags & IORESOURCE_CACHEABLE)
> > +               if (!force_nocache && (flags & IORESOURCE_CACHEABLE))
> >                         return ioremap(start, len);
> >                 return ioremap_nocache(start, len);
> >         }
> > 
> 
> ioremap is the same as ioremap_nocache, so this doesn't really make any
> sense. IORESOURCE_CACHEABLE is practically only set for ROM bars, which
> we rarely map.
> 
> 	Arnd

Hmm I think you are right.
It's an old patch - I think at one point in time we did set it when we
now set IORESOURCE_PREFETCH.
I'll drop this parameter.

-- 
MST
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization




[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux