* Zachary Amsden (zach at vmware.com) wrote: > Rusty Russell wrote: > >On Mon, 2006-07-31 at 01:50 -0700, Zachary Amsden wrote: > > > >>Rusty Russell wrote: > >> > >>>> fixmap-bootparam.patch > >>>> > >>>While this would justify the above patch, it is IMHO, the wrong approach > >>>for adding a paravirt module later: a module shouldn't fail to load > >>>because you forgot a boot cmdline param. I really think a #ifdef > >>>CONFIG_XXX_MODULE would be clearer. > >>> > >>We can't rely on a compile time kernel option - we really must have a > >>boot parameter. This is not the wrong approach. If you forgot to add > >>the boot parameter, so be it. You reboot and the paravirt module can > >>load. The whole approach only makes sense if you can fully virtualize > >>the kernel boot, so this is a completely plausible scenario. > >> > > > >The approach also makes sense for booting a kernel on native hardware, > >then inserting a hypervisor later (ie. turning it into dom0). I'll not > >be relying on an obscure cmdline boot option for that... > > > > But surely, you would provide room for it? I don't care how obscure it > is, I just care that it is possible. There was also some rumblings about this being useful for QEMU. Wouldn't a cmdline option be useful in that case? thanks -chris
