Rusty Russell wrote: > >>> The bigger immediate issue is that we seem to be having an emerging >>> tools compatibility problem; all those Index: lines you added will get >>> removed when I refresh the patch. I'm using the mercurial mq >>> extension, as is Rusty, and Chris is using a combination of mq and >>> quilt. What are you using? Why can't it deal with the patches? >>> >> I'm using yap, which is built on top of quilt. I fixed it to parse the >> patches properly, but it still leaves Index: lines when I regenerate >> patches, which I can't really help. >> > > OK, I hacked up a canonicalization script. Please use this before > checking in patch changes (just run bin/canonicalize-patches). > There's also the broader issue of different versions / options to patch generating different begin / end blobs, which seems to be generating a bunch of off by one spacing diffs when I create a patch. I must admit, my tools are fairly primitive, but I've not worked much with either patch sets or mercurial in the past, so I've got a bit of coming up to speed to do - hence the random hacking to get familiar with the process. Zach
