On Fri, Nov 08, 2013 at 01:09:47AM -0200, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > Commit 40ed51a4b (usb: chipidea: host: add vbus regulator > control) introduced a smatch complaint because regulator_disable() is called > without checking whether ci->platdata->reg_vbus is not NULL. > > Fix this by adding the check. > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > --- > drivers/usb/chipidea/host.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c > index 59e6020..526cd77 100644 > --- a/drivers/usb/chipidea/host.c > +++ b/drivers/usb/chipidea/host.c > @@ -88,7 +88,8 @@ static int host_start(struct ci_hdrc *ci) > return ret; > > disable_reg: > - regulator_disable(ci->platdata->reg_vbus); > + if (ci->platdata->reg_vbus) > + regulator_disable(ci->platdata->reg_vbus); > > put_hcd: > usb_put_hcd(hcd); > -- > 1.8.1.2 > > Applied, Thanks. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
