On Tue, Dec 03, 2013 at 07:48:30AM +0900, Jingoo Han wrote: > On Tuesday, December 03, 2013 7:26 AM, Sarah Sharp wrote: > > On Thu, Nov 28, 2013 at 11:08:13AM +0900, Jingoo Han wrote: > > > This macro is used to create a struct pci_device_id array. > > > > > > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > > > > Applied to my for-usb-next-queue branch. It will be queued to Greg's > > usb-next branch, and should be merged into 3.14. > > (+cc Joe Perches) > > Hi Sarah Sharp, > > Thank you for your review! :-) > However, this patch should NOT be merged. Ok, no worries, I'll remove this from my queue. > According to the Greg Kroah-Hartman, > "Yeah, and it's a horrid macro that deserves to be removed, please don't > use it in more places. > > Actually, if you could just remove it, that would be best, sorry, I'm > not going to take these patches." Ah, ok. I assume Greg responded to the cover letter patch for this patchset, and I missed it? That's why it's good to Cc everyone in the cover letter that's Cc'ed on other patches in the set. > So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead. > Sorry for annoying you. :-) In your patch to remove the macro, please make sure to remove the reference to DEFINE_PCI_DEVICE_TABLE in Documentation/PCI/pci.txt as well. I had never run across this macro before, and I trusted the documentation when it said "use of the macro DEFINE_PCI_DEVICE_TABLE is the preferred method of declaring the table". That's what I get for trusting out-of-date documentation, I guess. ;) Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
