On Tuesday, December 03, 2013 7:26 AM, Sarah Sharp wrote:
> On Thu, Nov 28, 2013 at 11:08:13AM +0900, Jingoo Han wrote:
> > This macro is used to create a struct pci_device_id array.
> >
> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
>
> Applied to my for-usb-next-queue branch. It will be queued to Greg's
> usb-next branch, and should be merged into 3.14.
(+cc Joe Perches)
Hi Sarah Sharp,
Thank you for your review! :-)
However, this patch should NOT be merged.
According to the Greg Kroah-Hartman,
"Yeah, and it's a horrid macro that deserves to be removed, please don't
use it in more places.
Actually, if you could just remove it, that would be best, sorry, I'm
not going to take these patches."
So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead.
Sorry for annoying you. :-)
Best regards,
Jingoo Han
>
> Sarah Sharp
>
> > ---
> > drivers/usb/host/xhci-pci.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index b8dffd5..3f75a32 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> > @@ -357,7 +357,7 @@ static const struct hc_driver xhci_pci_hc_driver = {
> > /*-------------------------------------------------------------------------*/
> >
> > /* PCI driver selection metadata; PCI hotplugging uses this */
> > -static const struct pci_device_id pci_ids[] = { {
> > +static DEFINE_PCI_DEVICE_TABLE(pci_ids) = { {
> > /* handle any USB 3.0 xHCI controller */
> > PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_USB_XHCI, ~0),
> > .driver_data = (unsigned long) &xhci_pci_hc_driver,
> > --
> > 1.7.10.4
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
