Hi Fabio
On Friday, November 29, 2013 10:14 AM, Fabio Estevam wrote:
Hi Chris,
On Fri, Nov 29, 2013 at 12:08 AM, Chris Ruehl<chris.ruehl@xxxxxxxxxxxx> wrote:
hw_phymode_configure configures the PORTSC registers and allow the
following phy_inits to operate on the right parameters. This fix a problem
where the UPLI (ISP1504) could not detected, because the Viewport was not
available and returns 0's only.
Signed-off-by: Chris Ruehl<chris.ruehl@xxxxxxxxxxxx>
I have already fixed this issue. It is in mainline now:
yeah, the hw_phymode_configure() was in the probe but not called before the
ci_usb_phy_init(ci) which triggers the inits in phy-generic.c (in my case)
My pending patches relay on this.
Did you move the hw_phy before the ci_usb_phy_init too ?
Chris
commit 03779f05be6dfc48de99763f6c845a003e1e40f3
Author: Fabio Estevam<fabio.estevam@xxxxxxxxxxxxx>
Date: Wed Aug 14 12:43:56 2013 +0300
usb: chipidea: move hw_phymode_configure() into probe
Currently hw_phymode_configure() is located inside hw_device_reset(), which
only called by chipidea udc driver.
When operating in host mode, we also need to call hw_phymode_configure() in
order to properly configure the PHY mode, so move this function into probe.
After this change, USB Host1 port on mx53qsb board is functional.
Signed-off-by: Fabio Estevam<fabio.estevam@xxxxxxxxxxxxx>
Tested-by: Arnaud Patard<arnaud.patard@xxxxxxxxxxx>
Reviewed-by: Peter Chen<peter.chen@xxxxxxxxxxxxx>
Signed-off-by: Alexander Shishkin<alexander.shishkin@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman<gregkh@xxxxxxxxxxxxxxxxxxx>
Regards,
Fabio Estevam
--
GTSYS Limited RFID Technology
A01 24/F Gold King Industrial Bld
35-41 Tai Lin Pai Road, Kwai Chung, Hong Kong
Fax (852) 8167 4060 - Tel (852) 3598 9488
Disclaimer: http://www.gtsys.com.hk/email/classified.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
