RE: [REWORKED PATCH 1/5] usb: phy: fsm: don't depend on indirect includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> On Wed, Nov 27, 2013 at 11:14:56AM +0900, Anton Tikhomirov wrote:
> > Hi Felipe,
> >
> > > Hi,
> > >
> > > On Tue, Nov 26, 2013 at 10:33:44AM -0600, Felipe Balbi wrote:
> > > > this header uses spinlocks and errno values, so
> > > > we must include <linux/spinlock.h> and <linux/errno.h>
> > > > to avoid build errors.
> > > >
> > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > >
> > > Anton, I had to rework your patch series quite a bit in order to
> make
> >
> > Thank you.
> >
> > > it
> > > acceptable. It seems unlikely that you compile-tested your series,
> > > considering we would very clearly see build errors after moving the
> > > header around.
> > >
> > > Your driver depends (or depended?) too much on indirect header
> > > inclusions.
> >
> > Currently only Freescale OTG Transceiver Driver uses OTG FSM. After
> applying
> > patches it was compiled without errors.
> 
> usually allmodconfig, allyesconfig, allnoconfig with different
> architectures uncovers a bunch of errors.

Thank you Felipe. I'll be more careful next time.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux