Re: [REWORKED PATCH 1/5] usb: phy: fsm: don't depend on indirect includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Nov 26, 2013 at 10:33:44AM -0600, Felipe Balbi wrote:
> this header uses spinlocks and errno values, so
> we must include <linux/spinlock.h> and <linux/errno.h>
> to avoid build errors.
> 
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>

Anton, I had to rework your patch series quite a bit in order to make it
acceptable. It seems unlikely that you compile-tested your series,
considering we would very clearly see build errors after moving the
header around.

Your driver depends (or depended?) too much on indirect header
inclusions.

Make sure to build test each and every patch in your series next time,
or they won't make it to mainline.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux