Assuming you update the description with Oliver's suggestion, this looks
fine.
Sarah Sharp
On Fri, Aug 23, 2013 at 11:15:04AM +0300, Xenia Ragiadakou wrote:
> This patch refactors the code in TRB_DISABLE_SLOT switch case in
> handle_cmd_completion() into a fuction named xhci_handle_cmd_disable_slot().
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> ---
> drivers/usb/host/xhci-ring.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 0abf88c..f9c380e 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1380,6 +1380,19 @@ static void xhci_handle_cmd_enable_slot(struct xhci_hcd *xhci, int slot_id,
> complete(&xhci->addr_dev);
> }
>
> +static void xhci_handle_cmd_disable_slot(struct xhci_hcd *xhci, int slot_id)
> +{
> + struct xhci_virt_device *virt_dev;
> +
> + virt_dev = xhci->devs[slot_id];
> + if (!virt_dev)
> + return;
> + if (xhci->quirks & XHCI_EP_LIMIT_QUIRK)
> + /* Delete default control endpoint resources */
> + xhci_free_device_endpoint_resources(xhci, virt_dev, true);
> + xhci_free_virt_device(xhci, slot_id);
> +}
> +
> static void handle_cmd_completion(struct xhci_hcd *xhci,
> struct xhci_event_cmd *event)
> {
> @@ -1431,13 +1444,7 @@ static void handle_cmd_completion(struct xhci_hcd *xhci,
> GET_COMP_CODE(le32_to_cpu(event->status)));
> break;
> case TRB_TYPE(TRB_DISABLE_SLOT):
> - if (xhci->devs[slot_id]) {
> - if (xhci->quirks & XHCI_EP_LIMIT_QUIRK)
> - /* Delete default control endpoint resources */
> - xhci_free_device_endpoint_resources(xhci,
> - xhci->devs[slot_id], true);
> - xhci_free_virt_device(xhci, slot_id);
> - }
> + xhci_handle_cmd_disable_slot(xhci, slot_id);
> break;
> case TRB_TYPE(TRB_CONFIG_EP):
> virt_dev = xhci->devs[slot_id];
> --
> 1.8.3.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
