This looks fine as well.
Sarah Sharp
On Fri, Aug 23, 2013 at 11:15:05AM +0300, Xenia Ragiadakou wrote:
> This patch refactors the code in TRB_ADDR_DEV switch case in
> handle_cmd_completion() into a fuction named xhci_handle_cmd_addr_dev().
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> ---
> drivers/usb/host/xhci-ring.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index f9c380e..f00d9ef 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1393,6 +1393,13 @@ static void xhci_handle_cmd_disable_slot(struct xhci_hcd *xhci, int slot_id)
> xhci_free_virt_device(xhci, slot_id);
> }
>
> +static void xhci_handle_cmd_addr_dev(struct xhci_hcd *xhci, int slot_id,
> + u32 cmd_comp_code)
> +{
> + xhci->devs[slot_id]->cmd_status = cmd_comp_code;
> + complete(&xhci->addr_dev);
> +}
> +
> static void handle_cmd_completion(struct xhci_hcd *xhci,
> struct xhci_event_cmd *event)
> {
> @@ -1505,8 +1512,8 @@ bandwidth_change:
> complete(&xhci->devs[slot_id]->cmd_completion);
> break;
> case TRB_TYPE(TRB_ADDR_DEV):
> - xhci->devs[slot_id]->cmd_status = GET_COMP_CODE(le32_to_cpu(event->status));
> - complete(&xhci->addr_dev);
> + xhci_handle_cmd_addr_dev(xhci, slot_id,
> + GET_COMP_CODE(le32_to_cpu(event->status)));
> break;
> case TRB_TYPE(TRB_STOP_RING):
> xhci_handle_cmd_stop_ep(xhci, xhci->cmd_ring->dequeue, event);
> --
> 1.8.3.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
