Re: [RFC v3 03/18] xhci: refactor TRB_ENABLE_SLOT case into function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 25, 2013 at 02:25:54AM +0300, Xenia Ragiadakou wrote:
> On 08/25/2013 12:48 AM, Oliver Neukum wrote:
> >On Fri, 2013-08-23 at 11:15 +0300, Xenia Ragiadakou wrote:
> >>This patch refactors the code in TRB_ENABLE_SLOT switch case in
> >>handle_cmd_completion() into a fuction named xhci_handle_cmd_enable_slot().
> >Hi,
> >
> >it would be nice, in fact probably a requirement, for
> >the commit message to explain what the benefit of the
> >change is.
> >That is, does it improve readability or something else?
> >
> >	Regards
> >		Oliver
> >
> >
> 
> 
> I see, i will fix this in the next version of this RFC.

I would just add two sentences to each of these refactoring patches to
the effect of:

The function that handles xHCI command completion is much too long.
Break it up into individual functions for each command completion.

Assuming you do this, this patch looks fine.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux