Greg KH <greg@xxxxxxxxx> writes: > On Sat, Aug 17, 2013 at 03:34:32PM -0600, Anthony Foiani wrote: > > +int USBIP_PORT = 3240; > > +char *USBIP_PORT_STRING = "3240"; > > Variables shouldn't be ALL_CAPS, those are what #defines are for. > Yes, I know you moved from a define to a variable, Right, I was trying to minimize churn. Guess I should have followed with another patch to convert to sane usage. > but please make it obvious and change the name as well, otherwise > stuff like: > >> + USBIP_PORT = port; >> + USBIP_PORT_STRING = arg; > > Just makes my head hurt. Ok. Will try to respin in the next few days. Thanks! Tony -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
