Re: [PATCH v2 2/4] staging: usbip: set usbipd server port via "-t" / "--tcp-port" option.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 17, 2013 at 03:34:32PM -0600, Anthony Foiani wrote:
> +int USBIP_PORT = 3240;
> +char *USBIP_PORT_STRING = "3240";

Variables shouldn't be ALL_CAPS, those are what #defines are for.  Yes,
I know you moved from a define to a variable, but please make it obvious
and change the name as well, otherwise stuff like:

> +	USBIP_PORT = port;
> +	USBIP_PORT_STRING = arg;

Just makes my head hurt.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux