Re: [PATCH v2 1/4] staging: usbip: add "-P" / "--pid" option to save usbipd process id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes:

> On Sat, Aug 17, 2013 at 03:34:31PM -0600, Anthony Foiani wrote:
> > Introduce option "-P" / "--pid" to request that usbipd save its
> > PID to a file while running.
>
> Shouldn't this be the requirement of the tool that starts it up
> (i.e.  systemd or sysvinit)?  Putting stuff like /var/run into the
> daemon seems like a bad idea.

By that logic, we should remove the daemonize code entirely, since one
can't otherwise get the PID post-daemonize.

(I'll admit that I'm using it in a project that has no init scripts,
so I'd carry this change regardless.)

Finally, the "/var/run/usbipd.pid" is just a default; the user is
welcome to specify whatever path their distribution or layout
requires.  (Assuming I coded the getopt bits correctly!)

As always, feel free to drop.  I just wanted to follow up on my
previous patches with a more final version, in case anyone else needs
or wants these features.

Thanks,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux