On Wed, Aug 07, 2013 at 05:24:45PM +0800, Peter Chen wrote: > On Wed, Aug 07, 2013 at 12:05:07PM +0200, Sascha Hauer wrote: > > > > > > We need to know controller number, like pdev->id in the past. > > > The registers at non core register is messy, the specific bit > > > is for specific controller. > > > > The controller number is present in the old binding: > > > > fsl,usbmisc = <&usbmisc 1>; > > ^^^ > > > > Merging the usbmisc stuff into the imx driver shouldn't be a reason to > > change this binding. > > > > Please get used to the fact that dt bindings cannot be changed easily > > just because the newer binding looks nicer. They define an ABI and > > breaking this ABI causes pain. > > > > But current situation is the device node of "usbmisc" will not be needed. If it's really not needed then you could remove it. > The usbmisc will not be a driver. Not true. It's still a driver, just one that happens to be not compilable as module: syscon > We only need usbmisc to supply kinds > of SoC specific implementations, as well as filling the content of the data > at struct of_device_id (imx-usb's). Yes, that's the purpose of usbmisc and ever has been. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html