On Sat, Jul 27, 2013 at 01:34:42PM +0200, Johan Hovold wrote:
> Silence compiler warnings on 64-bit systems introduced by commit
> 05cf0dec ("USB: mos7840: fix race in led handling") which uses the
> usb-serial data pointer to temporarily store the device type during
> probe but failed to add the required casts.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
> ---
> drivers/usb/serial/mos7840.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index c10fc15..6350628 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -2221,14 +2221,14 @@ static int mos7840_probe(struct usb_serial *serial,
>
> kfree(buf);
> out:
> - usb_set_serial_data(serial, (void *)device_type);
> + usb_set_serial_data(serial, (void *)(uintptr_t)device_type);
Really? uintptr_t isn't a "normal" kernel type.
> static int mos7840_calc_num_ports(struct usb_serial *serial)
> {
> - int device_type = (int)usb_get_serial_data(serial);
> + int device_type = (uintptr_t)usb_get_serial_data(serial);
Odd, as usb_get_serial_data() returns a void, casting it to an int
should work...
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
