Re: [PATCH 2/3] USB: mos7840: fix device-type detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 26, 2013 at 11:55:18AM +0200, Johan Hovold wrote:
> Fix race in device-type detection introduced by commit 0eafe4de ("USB:
> serial: mos7840: add support for MCS7810 devices") which used a static
> variable to hold the device type.
> 
> Move type detection to probe and use serial data to store the device
> type.

I'm getting the following build warnings after applying these patches:

  CC [M]  drivers/usb/serial/mos7840.o
drivers/usb/serial/mos7840.c: In function ‘mos7840_probe’:
drivers/usb/serial/mos7840.c:2224:30: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
drivers/usb/serial/mos7840.c: In function ‘mos7840_calc_num_ports’:
drivers/usb/serial/mos7840.c:2231:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/usb/serial/mos7840.c: In function ‘mos7840_port_probe’:
drivers/usb/serial/mos7840.c:2242:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

Can you send me a follow-on patch to fix them up?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux