RE: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Felipe Balbi [mailto:balbi@xxxxxx]
> Sent: Friday, July 26, 2013 2:54 AM
> > > > Also, this is not *modifying* what was passed, just skipping the xHCI
> > > > address space so we don't request_mem_region() an area we won't really
> > > > handle and prevent xhci-hcd.ko from probing.
> > >
> > > Hmm? platform_get_resource() returns a pointer to an entry in the
> > > platform_device's resource[] array. And "res->start +=" modifies the
> > > entry pointed at. If it didn't, the bug fixed by this patch wouldn't
> > > have happened.
> > >
> > > Are you sure this code will work OK if you build the driver as a module,
> > > modprobe it, rmmod it, and then modprobe it again? Seems like it won't,
> > > unless the dev->resource[] array gets reinitialized in between somehow.
> 
> gotta try that one... Perhaps the correct way would be to copy the
> resource to a private struct resource and modify that one, leaving
> pdev->resources untouched.

Maybe this is a dumb question, but why can't the driver that is going
to use the resource after this just "know" that it has to add
DWC3_GLOBALS_REGS_START to the start address? Are there some versions
of the core where that is not the case?

Or, maybe there should be two sets of resources?

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux