On 07/10/2013 12:45 AM, Sarah Sharp wrote:
On Tue, Jul 09, 2013 at 10:23:46AM -0400, Alan Stern wrote:
On Tue, 9 Jul 2013, Felipe Balbi wrote:
On Mon, Jul 08, 2013 at 09:55:15PM -0700, Sarah Sharp wrote:
As far as I can tell, that means the setup packet for control transfers
doesn't actually get mapped for DMA currently. With Xenia's patch it
will.
That's a very good finding and I don't know how come we never triggered
it. I am sure we have OMAP5 working with that :-s
It's because of this line in usb_create_shared_hcd():
hcd->self.uses_dma = (dev->dma_mask != NULL);
As a result, HCDs shouldn't have to set this flag themselves.
Ok, so Xenia should just drop that line from her patch.
Sarah Sharp
I set the usb_bus uses_dma flag explicitly because usb_create_shared_hcd()
is called before usb_add_hcd() which will call the xhci_*_setup().
If dma_mask is unitialized, then this flag will be 0 for the usb_bus of
the primary
hcd because dma_mask will be null when usb_create_shared_hcd() will be
called
for the primary hcd.
This is my impression, at least. Maybe i miss a point.
regards,
ksenia
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
