Re: [RFC v3] xhci: fix dma mask setup in xhci.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 09, 2013 at 10:23:46AM -0400, Alan Stern wrote:
> On Tue, 9 Jul 2013, Felipe Balbi wrote:
> > On Mon, Jul 08, 2013 at 09:55:15PM -0700, Sarah Sharp wrote:
> > > As far as I can tell, that means the setup packet for control transfers
> > > doesn't actually get mapped for DMA currently.  With Xenia's patch it
> > > will.
> > 
> > That's a very good finding and I don't know how come we never triggered
> > it. I am sure we have OMAP5 working with that :-s
> 
> It's because of this line in usb_create_shared_hcd():
> 
> 	hcd->self.uses_dma = (dev->dma_mask != NULL);
> 
> As a result, HCDs shouldn't have to set this flag themselves.

Ok, so Xenia should just drop that line from her patch.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux