On 07:53-20130706, Ruchika Kharwar wrote: > When the initialization of usb3 phy fails, when enabled in the system > the dwc3_probe deferral is further qualified by the maximum speed. > In devices such as dra7xx, there are multiple dwc3 instances where the > maximum_speed is different between the instances. indentation. > > This patch depends on http://www.spinics.net/lists/linux-usb/msg88627.html Dependencies must be stated in diffstat - it is better to post a complete series unless this maybe a standalone - which it seems to be.. just my 2 cents. > > Signed-off-by: Ruchika Kharwar <ruchika@xxxxxx> > --- > drivers/usb/dwc3/core.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 7b98e4f..05f2205 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -460,8 +460,11 @@ static int dwc3_probe(struct platform_device *pdev) > if (ret == -ENXIO) > return ret; > > - dev_err(dev, "no usb3 phy configured\n"); > - return -EPROBE_DEFER; > + if (dwc->maximum_speed == USB_SPEED_SUPER) { > + dev_err(dev, "no usb3 phy configured\n"); > + return -EPROBE_DEFER; is deferal always the right solution? just curious if one does not declare the phy node, would'nt there be an opportunity to giveup earlier? > + } else > + dev_dbg(dev, "maximum speed is < super\n"); Checkpatch would have asked you to add {} on both branches of the if condition ;) > } > > usb_phy_set_suspend(dwc->usb2_phy, 0); > -- > 1.7.9.5 > -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
