Re: [PATCH 2/2] [RFC] usb: dwc3: using the maximum_speed to determine if the usb3 phy is needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 06-07-2013 16:53, Ruchika Kharwar wrote:

     When the initialization of usb3 phy fails, when enabled in the system
     the dwc3_probe deferral is further qualified by the maximum speed.
     In devices such as dra7xx, there are multiple dwc3 instances where the
     maximum_speed is different between the instances.

     This patch depends on http://www.spinics.net/lists/linux-usb/msg88627.html

   Don't indent the changelog please.

Signed-off-by: Ruchika Kharwar <ruchika@xxxxxx>
---
  drivers/usb/dwc3/core.c |    7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 7b98e4f..05f2205 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -460,8 +460,11 @@ static int dwc3_probe(struct platform_device *pdev)
  		if (ret == -ENXIO)
  			return ret;

-		dev_err(dev, "no usb3 phy configured\n");
-		return -EPROBE_DEFER;
+		if (dwc->maximum_speed == USB_SPEED_SUPER) {
+                       dev_err(dev, "no usb3 phy configured\n");
+                       return -EPROBE_DEFER;
+               } else
+                       dev_dbg(dev, "maximum speed is < super\n");

According to Documenation/CodingStyle chapter 3, there should be {} on both arms of the *if* statement if one arm has it.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux