On Fri, Jul 05, 2013 at 03:51:30PM +0300, Roger Quadros wrote:
> On 07/02/2013 12:31 PM, Felipe Balbi wrote:
> > On Tue, Jul 02, 2013 at 10:42:12AM +0200, Sebastian Andrzej Siewior wrote:
> >> On 07/02/2013 10:26 AM, Felipe Balbi wrote:
> >>> alright, how about this ? I'll split dr_mode documentation to a
> >>> separate patch soon and resend with devicetree-discuss in the
> >>> loop.
> >>
> >> Okay.
> >>
> >>> diff --git a/Documentation/devicetree/bindings/usb/generic.txt
> >>> b/Documentation/devicetree/bindings/usb/generic.txt new file mode
> >>> 100644 index 0000000..623e360 --- /dev/null +++
> >>> b/Documentation/devicetree/bindings/usb/generic.txt @@ -0,0 +1,25
> >>> @@ +Generic USB Properties + +Optional properties: + -
> >>> maximum-speed: tells USB controllers we want to work up to a
> >>> certain + speed. Valid arguments are "super-speed",
> >>> "high-speed", + "full-speed" and "low-speed". In case this isn't
> >>> passed + via DT, USB controllers should default to their maximum
> >>> + HW capability. + - dr_mode: tells Dual-Role USB controllers
> >>> that we want to work on a + particular mode. Valid arguments are
> >>> "host", + "peripheral" and "otg". In case this attribute isn't +
> >>> passed via DT, USB DRD controllers should default to + OTG. +
> >>> +This is an attribute to a USB controller such as: + +dwc3@4a030000
> >>> { + compatible = "synopsys,dwc3"; + reg = <0x4a030000 0xcfff>; +
> >>> interrupts = <0 92 4> + usb-phy = <&usb2_phy>, <&usb3,phy>;
> >>
> >> Two things:
> >> - we seem to use usb-phy and phys. Couldn't we just stick to one?
> >> - usb-phy is optional, isn't it?
> >
> > phys comes from the new PHY layer which isn't merged yet.
> >
> >>> + tx-fifo-resize;
> >> this one is dwc3 specific right? The other two (max speed & dr_mode)
> >> look generic enough.
> >
> > alright. Here's a new version
> >
> > commit e09b284cf5879863ea2b0ad6568cfbbd7131ac0c
> > Author: Felipe Balbi <balbi@xxxxxx>
> > Date: Sun Jun 30 13:56:45 2013 +0300
> >
> > usb: common: introduce of_usb_get_maximum_speed()
> >
> > this helper will be used for controllers which
> > want to work at a lower speed even though they
> > support higher USB transfer rates.
> >
> > One such case is Texas Instruments' AM437x
> > SoC where it uses a USB3 controller without
> > a USB3 PHY, rendering the controller USB2-only.
> >
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> >
> > diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt
> > new file mode 100644
> > index 0000000..477d5bb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/generic.txt
> > @@ -0,0 +1,24 @@
> > +Generic USB Properties
> > +
> > +Optional properties:
> > + - maximum-speed: tells USB controllers we want to work up to a certain
> > + speed. Valid arguments are "super-speed", "high-speed",
> > + "full-speed" and "low-speed". In case this isn't passed
> > + via DT, USB controllers should default to their maximum
> > + HW capability.
> > + - dr_mode: tells Dual-Role USB controllers that we want to work on a
> > + particular mode. Valid arguments are "host",
> > + "peripheral" and "otg". In case this attribute isn't
> > + passed via DT, USB DRD controllers should default to
> > + OTG.
>
> IMO "dr-mode" is better than "dr_mode" for consistency.
I agree, but there are already users of dr_mode and, as you can expect,
changing ABI is tough :-)
--
balbi
Attachment:
signature.asc
Description: Digital signature
