On 07/02/2013 10:10 AM, Felipe Balbi wrote: > Hi, Hi Felipe, > On Tue, Jul 02, 2013 at 10:06:23AM +0200, Sebastian Andrzej Siewior > wrote: >> On 07/01/2013 09:18 AM, Felipe Balbi wrote: >>> diff --git a/drivers/usb/usb-common.c >>> b/drivers/usb/usb-common.c index 675384d..b87f202 100644 --- >>> a/drivers/usb/usb-common.c +++ b/drivers/usb/usb-common.c > uhm... this is usb-common.c Oh. >> This looks tricky. If you copy that property unconditionally than >> you will end up with UNKNOWN speed if that property is missing >> and no gadget will load, right? If so, maybe a second argument >> would be nice > > UDC should be required to treat UNKOWN as maximum-speed not being > passed and, thus, fixing it to the maximum the HW supports. > >> which would be used as the default speed if none is found in DT. >> Unless you want to do that check in each and every driver. > > I don't mind either way although I find it funny to pass a > 'default' argument which just gets returned back to the caller if > maximum-speed isn't available. Yeah. Never mind then. > Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
