-----Original Message----- From: Wei Yongjun [mailto:weiyj.lk@xxxxxxxxx] Sent: Tuesday, May 21, 2013 10:41 AM To: gregkh@xxxxxxxxxxxxxxxxxxx; Wendy Yuan-Hsin Chen(陳元馨) Cc: yongjun_wei@xxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx Subject: [PATCH -next] usb: fusbh200-hcd: fix error handling in fusbh200_hcd_fusbh200_probe() From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> Fix to release all resources when fusbh200_setup() fail instead of only return error. Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> Acked-by: Yuan-Hsin Chen <yhchen@xxxxxxxxxxxxxxxx> --- drivers/usb/host/fusbh200-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c index 79ce799..7f3293b 100644 --- a/drivers/usb/host/fusbh200-hcd.c +++ b/drivers/usb/host/fusbh200-hcd.c @@ -5864,7 +5864,7 @@ static int fusbh200_hcd_fusbh200_probe(struct platform_device *pdev) retval = fusbh200_setup(hcd); if (retval) - return retval; + goto fail_add_hcd; fusbh200_init(fusbh200); ********************* Confidentiality Notice ************************ This electronic message and any attachments may contain confidential and legally privileged information or information which is otherwise protected from disclosure. If you are not the intended recipient,please do not disclose the contents, either in whole or in part, to anyone,and immediately delete the message and any attachments from your computer system and destroy all hard copies. Thank you for your cooperation. *********************************************************************** ?頨{.n?????%??橆??w?{.n???{殺???緡w*jg炳????▏?拷G??98夸:+v??鋟喓???茶庫全??ㄑ搬?????