Re: [PATCH -next] usb: fusbh200-hcd: fix error handling in fusbh200_hcd_fusbh200_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 31, 2013 at 02:35:41AM +0000, Wendy Yuan-Hsin Chen(陳元馨) wrote:
> 
> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@xxxxxxxxx] 
> Sent: Tuesday, May 21, 2013 10:41 AM
> To: gregkh@xxxxxxxxxxxxxxxxxxx; Wendy Yuan-Hsin Chen(陳元馨)
> Cc: yongjun_wei@xxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx
> Subject: [PATCH -next] usb: fusbh200-hcd: fix error handling in fusbh200_hcd_fusbh200_probe()

Why the forward of a previous patch?  I don't see this original one in
my mailboxes anywhere, what happened to it?

> 
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> Fix to release all resources when fusbh200_setup() fail instead of only return error.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> Acked-by: Yuan-Hsin Chen <yhchen@xxxxxxxxxxxxxxxx>
> 
> ---
>  drivers/usb/host/fusbh200-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c index 79ce799..7f3293b 100644
> --- a/drivers/usb/host/fusbh200-hcd.c
> +++ b/drivers/usb/host/fusbh200-hcd.c
> @@ -5864,7 +5864,7 @@ static int fusbh200_hcd_fusbh200_probe(struct platform_device *pdev)
>  
>  	retval = fusbh200_setup(hcd);
>  	if (retval)
> -		return retval;
> +		goto fail_add_hcd;
>  
>  	fusbh200_init(fusbh200);
>  
> 
> 
> ********************* Confidentiality Notice ************************
> This electronic message and any attachments may contain
> confidential and legally privileged information or
> information which is otherwise protected from disclosure.
> If you are not the intended recipient,please do not disclose
> the contents, either in whole or in part, to anyone,and
> immediately delete the message and any attachments from
> your computer system and destroy all hard copies.
> Thank you for your cooperation.
> ***********************************************************************

This footer prevents me from being able to apply your patch, please
remove it and resend it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux