On Sat, 18 May 2013, Hans de Goede wrote: > Hi, > > As written in my mail titled: "Linux sysfs usb descriptors > file has broken configuration length handling" > > I've been taking a close look at the usb sysfs handling > code, specifically for the descriptors sysfs file. > > One other difference I've noticed is that the usbfs > code for reading the descriptors does a usb_lock_device, > whereas read_descriptors for the sysfs descriptors file > does not. Unless I'm mistaken that means the sysfs > code can race with (re)-enumeration and bad things could > happen. > > Similar concerns apply to the other usb sysfs files. It's true that several of the attribute routines in sysfs.c don't include proper locking. I started to work on this some time ago (back around the 3.5 time frame, or maybe earlier) but never finished up. Maybe I should go back and complete the work. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
