Hi Fabio, I remebered devm_pinctrl_get_select_default will be returned successfully. Otherwise, how the patch included this code was tested? Best regards, Peter Chen ________________________________________ From: Fabio Estevam [festevam@xxxxxxxxx] Sent: Sunday, April 28, 2013 3:28 AM To: Chen Peter-B29397 Cc: Uwe Kleine-König; Alexander Shishkin; gregkh@xxxxxxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; Estevam Fabio-R49496; mkl@xxxxxxxxxxxxxx; m.grzeschik@xxxxxxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx Subject: Re: [PATCH] usb: chipidea: ci13xxx_imx: Use dev_dbg for pinctrl message On Fri, Apr 26, 2013 at 10:22 PM, Peter Chen <peter.chen@xxxxxxxxxxxxx> wrote: > This pin is ID pin for OTG controller, some platforms use dedicated ID pin > which doesn't need to config pinctrl.(mx53, etc), some platforms can > choose ID pin from IOMUXC using pinctrl interface. Actually it is not only OTG ID pin, it can be any USB pin. Currently the i.MX device tree does not pass pinctrl node, so that's why devm_pinctrl_get_select_default fails. > I suggest that it uses of_match_table to differentiate platforms, and > import new function ci_imx_init to cover it. It may not the only > different things among i.mx SoC USB controllers. I don't understand what you explained here, but anyway it seems like a different issue. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
