On Fri, Apr 26, 2013 at 03:36:42PM +0300, Alexander Shishkin wrote: > Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> writes: > > > On Wed, Apr 24, 2013 at 02:19:19PM -0300, Fabio Estevam wrote: > >> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > >> > >> Currently we always get the following message during boot: > >> > >> imx_usb 80080000.usb: pinctrl get/select failed, err=-19 > >> > >> ,which is not very useful during standard usage. > >> > >> Move it to dev_dbg. > > Is it a real problem when devm_pinctrl_get_select_default fails? What > > would be needed to make the call succeed? > > In author's words, some controllers don't need it, so it's ok if it > fails. Printing warning in that case is not a good idea, so I agree with > Fabio. I'll apply it soon unless I hear from people involved with > chipidea on imx. Next thing we need to agree on if this bit belongs to > platform or core, which is not obvious, and the patch that introduced > this code doesn't clarify why exactly this is needed. I suggest to improve the commit log to include your explanation. I wonder that it fails on imx because I thought pinctrl is up and running there? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
