Re: [PATCH] usb: chipidea: ci13xxx_imx: Use dev_dbg for pinctrl message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> writes:

> On Wed, Apr 24, 2013 at 02:19:19PM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>> 
>> Currently we always get the following message during boot:
>> 
>> imx_usb 80080000.usb: pinctrl get/select failed, err=-19         
>> 
>> ,which is not very useful during standard usage.
>> 
>> Move it to dev_dbg.
> Is it a real problem when devm_pinctrl_get_select_default fails? What
> would be needed to make the call succeed?

In author's words, some controllers don't need it, so it's ok if it
fails. Printing warning in that case is not a good idea, so I agree with
Fabio. I'll apply it soon unless I hear from people involved with
chipidea on imx. Next thing we need to agree on if this bit belongs to
platform or core, which is not obvious, and the patch that introduced
this code doesn't clarify why exactly this is needed.

Cc'ing the chipidea crowd (hey, anyone wants to set up a mail alias? :))
in case they have something to say on the topic.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux