On Tuesday 16 April 2013, manjunath.goudar@xxxxxxxxxx wrote:
> From: Manjunath Goudar <manjunath.goudar@xxxxxxxxxx>
>
> This patch prepares ohci-hcd for being split up into a core
> library and separate platform driver modules. A generic
> ohci_hc_driver structure is created, containing all the "standard"
> values, and a new mechanism is added whereby a driver module can
> specify a set of overrides to those values. In addition the
> ohci_init(),ohci_restart(),ohci_hcd_init(),ohci_run() ohci_stop(),
> ohci_suspend() and ohci_resume() routines need to be EXPORTed
> for use by the drivers.
>
> Signed-off-by: Manjunath Goudar <manjunath.goudar@xxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Greg KH <greg@xxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
Hi Manjunath,
This looks nice I think, but let's see what Alan has to say about it.
I did not see any information in your description about how you
tested the changes. Are you able to use any USB-1.1 devices with
this on a PC, using ohci-pci as a loadable module?
> +
> +#if defined(CONFIG_PM) || defined(CONFIG_PCI)
> +extern int ohci_restart (struct ohci_hcd *ohci);
> +#else
> +static inline int ohci_restart (struct ohci_hcd *ohci)
> +{
> + return;
> +}
> +#endif
I looked at who calls ohci_restart, and I don't think the #else clause
is actually needed here, or the "return" for that matter.
Just declare the function unconditionally.
I would also remove the space after the ohci_restart identifier, since
that is the common coding style.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
