On Tue, 16 Apr 2013 manjunath.goudar@xxxxxxxxxx wrote: > From: Manjunath Goudar <manjunath.goudar@xxxxxxxxxx> > > This patch prepares ohci-hcd for being split up into a core > library and separate platform driver modules. A generic > ohci_hc_driver structure is created, containing all the "standard" > values, and a new mechanism is added whereby a driver module can > specify a set of overrides to those values. In addition the > ohci_init(),ohci_restart(),ohci_hcd_init(),ohci_run() ohci_stop(), > ohci_suspend() and ohci_resume() routines need to be EXPORTed > for use by the drivers. This is a good start, but it goes too far by exporting routines that ought to be private. ohci_hcd_init, ohci_run, and ohci_stop should not be called by bus glue modules: ohci_hcd_init doesn't need to be called by glue modules at all, since ohci_init already calls it. Glue modules should not override ohci_hc_driver.start. Stuff like the code at the start of ohci_pci_start can be moved to the end of the module's reset routine. Likewise, glue modules should not need to call ohci_stop. If ohci_run fails, it should call ohci_stop itself. Lastly, I agree with Arnd that sb800_prefetch should be moved to the pci-quirks.c file. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
