> From: Matthijs Kooijman [mailto:matthijs@xxxxxxxx] > Sent: Friday, April 12, 2013 2:33 PM > > On Fri, Apr 12, 2013 at 09:09:51PM +0000, Paul Zimmerman wrote: > > > From: Matthijs Kooijman [mailto:matthijs@xxxxxxxx] > > > Sent: Friday, April 12, 2013 3:42 AM > > > > > > This adds a dwc_platform.ko module that can be loaded by using > > > compatible = "snps,dwc2" in a device tree. > > > > > > Signed-off-by: Matthijs Kooijman <matthijs@xxxxxxxx> > > > > > > --- > > > v2: remove useless debug prints > > > change module author and copyright > > > use "usb" in devicetree example instead of "otg" > > > --- > > > Documentation/devicetree/bindings/staging/dwc2.txt | 15 +++ > > > drivers/staging/dwc2/Kconfig | 6 +- > > > drivers/staging/dwc2/Makefile | 2 + > > > drivers/staging/dwc2/platform.c | 145 +++++++++++++++++++++ > > > 4 files changed, 166 insertions(+), 2 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/staging/dwc2.txt > > > create mode 100644 drivers/staging/dwc2/platform.c > > > > ... > > > > > diff --git a/drivers/staging/dwc2/platform.c b/drivers/staging/dwc2/platform.c > > > new file mode 100644 > > > index 0000000..9662c00 > > > > ... > > > > > +static const struct of_device_id dwc2_of_match_table[] = { > > > + { .compatible = "snps,dwc2" }, > > > + {}, > > > +}; > > > +MODULE_DEVICE_TABLE(of, dwc2_otg_match_table); > > > > Did you compile this? dwc2_otg_match_table != dwc2_of_match_table > > Ah, I didn't try compiling as a module, which is of course an oversight. > I'll see if I can find some time tomorrow, and otherwise monday, to fix > this and actually test the module loading on my hardware. Also, at the top of dwc2_driver_probe() there is a call to dwc2_set_all_params(), which is in a different module and thus won't link. I think that shouldn't be there anyway, since it is already called in dwc2_hcd_init(). You should also make dwc2_set_all_params() a static function and remove its declaration from hcd.h. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
