Re: [PATCH 3/4 v2] staging: dwc2: add platform device bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

On Fri, Apr 12, 2013 at 09:09:51PM +0000, Paul Zimmerman wrote:
> > From: Matthijs Kooijman [mailto:matthijs@xxxxxxxx]
> > Sent: Friday, April 12, 2013 3:42 AM
> > 
> > This adds a dwc_platform.ko module that can be loaded by using
> > compatible = "snps,dwc2" in a device tree.
> > 
> > Signed-off-by: Matthijs Kooijman <matthijs@xxxxxxxx>
> > 
> > ---
> > v2: remove useless debug prints
> >     change module author and copyright
> >     use "usb" in devicetree example instead of "otg"
> > ---
> >  Documentation/devicetree/bindings/staging/dwc2.txt |  15 +++
> >  drivers/staging/dwc2/Kconfig                       |   6 +-
> >  drivers/staging/dwc2/Makefile                      |   2 +
> >  drivers/staging/dwc2/platform.c                    | 145 +++++++++++++++++++++
> >  4 files changed, 166 insertions(+), 2 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/staging/dwc2.txt
> >  create mode 100644 drivers/staging/dwc2/platform.c
> 
> ...
> 
> > diff --git a/drivers/staging/dwc2/platform.c b/drivers/staging/dwc2/platform.c
> > new file mode 100644
> > index 0000000..9662c00
> 
> ...
> 
> > +static const struct of_device_id dwc2_of_match_table[] = {
> > +	{ .compatible = "snps,dwc2" },
> > +	{},
> > +};
> > +MODULE_DEVICE_TABLE(of, dwc2_otg_match_table);
> 
> Did you compile this?  dwc2_otg_match_table != dwc2_of_match_table

Ah, I didn't try compiling as a module, which is of course an oversight.
I'll see if I can find some time tomorrow, and otherwise monday, to fix
this and actually test the module loading on my hardware.

Gr.

Matthijs
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux